[Xcb] please test: Xlib/XCB fixes

Nicholas Allen nick.allen at onlinehome.de
Tue May 11 08:22:55 PDT 2010


Sorry I couldn't get back to you sooner. I've built and tested the
latest XCB from git master and so far everything looks good ;-)

I haven't had a lock up yet and normally got them very often so seems to
be that that nasty thread locking bug is finally squashed. I'll let you
know if I see it happen again though - I've only managed to do a few
hours testing with it so far (so might be premature to say it's
definitely fixed).

Cheers,

Nick

Jamey Sharp wrote:
> I guess I'm not going to get much review or testing of these patches
> while they're on a branch, so I've just pushed them to libX11 master.
> I've been running libX11 patched this way for about three weeks with
> no apparent problems, and the patches make multi-threaded ico
> completely work as far as I can tell, so I think they're a win.
>
> Testing and review would still be welcome though. :-)
>
> Jamey
>
> On Sun, Apr 18, 2010 at 11:33 PM, Jamey Sharp <jamey at minilop.net> wrote:
>   
>> Josh and I sorted out a bunch of Xlib bugs this week, especially in
>> support for multi-threaded applications. I'm embarrassed that I hadn't
>> realized the thread support was so bad--but there are so few threaded
>> Xlib apps, and even fewer that are open source.
>>
>> One important fix is in libxcb master. Several more fixes are in libX11
>> master, but my invasive rework of xcb_io.c is in an
>> xlib-xcb-thread-fixes branch pending testing and/or review.
>>
>> http://cgit.freedesktop.org/xorg/lib/libX11/log/?h=xlib-xcb-thread-fixes
>>
>> These changes need testing to make sure I didn't introduce regressions
>> for the single-threaded applications that were already working. And of
>> course, if anyone has multi-threaded apps that were failing, please
>> retest them and let me know if these patches helped.
>>
>> Also, please review these patches. The final patch of the libX11 series
>> adds lots of comments--including things I had to explain to Josh while
>> he was reviewing--and the new invariants it maintains are relatively
>> straightforward, so I hope others can make sense of it too.
>>
>> While most of the bugs we fixed affected only clients using the
>> connection from multiple threads, some additional fixes affect
>> single-threaded applications as well. I believe at least these bugs have
>> been solved by these changes:
>>
>> - https://bugs.freedesktop.org/show_bug.cgi?id=26545
>> - https://bugs.freedesktop.org/show_bug.cgi?id=27595
>> - http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=535534
>>
>> If you can take some time to go through your favorite bug tracking
>> system looking for other bugs that sound relevant, please do. Since I
>> have all this stuff swapped in now, this would be a good time to bring
>> more Xlib/XCB-related bug reports to my attention... :-)
>>
>> Hoping to be Done With Xlib any day now,
>> Jamey
>>
>> -----BEGIN PGP SIGNATURE-----
>> Version: GnuPG v1.4.10 (GNU/Linux)
>>
>> iEYEARECAAYFAkvL+R4ACgkQp1aplQ4I9mXHsACfYePmzD1F226+WMxao5OsygZu
>> /agAniScnI4oUYDbvS5MN/A5Mc79cg6z
>> =hg6H
>> -----END PGP SIGNATURE-----
>>
>>
>>     
> _______________________________________________
> Xcb mailing list
> Xcb at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/xcb
>   



More information about the Xcb mailing list