[Xcb] libxcb on interix (and/or platforms without getaddrinfo())

[Josh Triplett]

On Wed, Jun 15, 2011 at 07:52:00AM +0200, Markus Duft wrote:
> On 06/09/11 05:35, Josh Triplett wrote:
> > On Wed, Jun 08, 2011 at 10:01:02AM +0200, Markus Duft wrote:
> >> On 06/07/11 17:50, Josh Triplett wrote:
> >>> The duplication of some of the setup code, such as the setsockopt calls,
> >>> bugs me a bit, but I don't see an easy way to fix it.  (Tempted to
> >>> suggest using gethostbyname to provide a getaddrinfo function, but that
> >>> seems like overkill.)
> >>
> >> i could use a macro for this... i attached a version of the patch with this macro, please review.
> > 
> > Factoring out the common bits would definitely help, but please don't
> > use a macro; you can get the same effect with a static function without
> > dealing with the preprocessor.
> 
> i did that and attached the patch to [1]. could you please review again? any open issues with the patch?
> 
> [1] https://bugs.freedesktop.org/show_bug.cgi?id=38137

That version of the patch looks acceptable to me.

Reviewed-by: Josh Triplett <josh at joshtriplett.org>