[Xcb] [PATCH] Prevent theoretical double free and leak on get_peer_sock_name.

Peter Harris pharris at opentext.com
Thu Mar 24 08:32:22 PDT 2011


On 2011-03-24 00:32, Arnaud Fontaine wrote:
> Hello,
> 
>     > From: Rami  Ylimäki <rami.ylimaki at vincit.fi> Variable new_sockname
>     > will leak  and sockname will be double freed if  both of the cases
>     > shown below are true.
> 
>     > 1. realloc succeeds and doesn't return the original pointer
>     > 2. calling socket_func fails
> 
> Yes, you're right. Thanks for the patch:
> Reviewed-by: Arnaud Fontaine <arnau at debian.org>

Pushed. Thanks.

Peter Harris
-- 
               Open Text Connectivity Solutions Group
Peter Harris                    http://connectivity.opentext.com/
Research and Development        Phone: +1 905 762 6001
pharris at opentext.com            Toll Free: 1 877 359 4866


More information about the Xcb mailing list