[Xcb] [Bug 41443] Fatal error message when we close libX11 window application.

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=41443

--- Comment #3 from Arvind Umrao <arvind.umrao at oracle.com> 2011-10-05 02:45:11 PDT ---
(In reply to comment #2)
> Review of attachment 51992 [details]:
> 
> You shouldn't set the EPIPE error. The _xcb_conn_shutdown function already
> signals the connection errors. So instead of checking for EPIPE, you could
> introduce a version of _xcb_conn_shutdown that would make it possible to give a
> specific value for xcb_connection_t::has_error. This value could then be used
> to display different error messages in IO error handler.

good review. Thanks 

But right now XCB gives message number EAGAIN. I do not think EAGAIN is very
appropriate error message when connection is already broken. If you think it is
correct error message, then I have another fix, just change default io error
hander of linX11, so that it does not generate fatal error for error case
EAGAIN.

Right now in XCB, xcb_connection_t::has_error is harcoded to one. As you said
xcb_connection_t::has_error is not very useful for IO handler and I do agree
with you. 

I will be happy if somehow libX11 error hander does not print fatal error
message, but print some sensible message.  

So we have two solutions, let me know which is best one
1) PATCH I have given, make errno= EPIPE , because legacy libX11 is also doing
the same. 

2) If you think XCB is giving correct error number, then just change default io
error hander of linX11, so that it does not generate fatal error for error case
EAGAIN.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.