[Xcb] [PATCH xcb/libxcb] Fatal error message when we close libX11 window application

Rami Ylimäki rami.ylimaki at vincit.fi
Mon Oct 17 05:27:01 PDT 2011


On 10/17/2011 01:44 PM, Arvind Umrao wrote:
>
>   void _xcb_conn_shutdown(xcb_connection_t *c)
>   {
> -    c->has_error = 1;
> +    c->has_error = EPIPE;
>   }

You set the error code unconditionally and assume that EPIPE occurred 
whenever _xcb_conn_shutdown is called. You should set the error code 
only after you have verified that EPIPE was actually the reason for 
breaking the connection.

-- Rami



More information about the Xcb mailing list