[Xcb] [PATCH lib] c_client.py: Do not create pointers in unions

Josh Triplett josh at joshtriplett.org
Fri Dec 28 16:18:57 PST 2012


On Fri, Dec 28, 2012 at 11:40:29PM +0100, Daniel Martin wrote:
> Do not create pointers in unions for fields of variadic length.
> 
> Signed-off-by: Daniel Martin <consume.noise at gmail.com>
> ---
> 
> With this patch xcb_xkb_doodad_t in xkb.h will change:
> 
>  typedef union xcb_xkb_doodad_t {
>      xcb_xkb_common_doodad_t    common; /**<  */
>      xcb_xkb_shape_doodad_t     shape; /**<  */
> -    xcb_xkb_text_doodad_t     *text; /**<  */
> +    xcb_xkb_text_doodad_t      text; /**<  */
>      xcb_xkb_indicator_doodad_t indicator; /**<  */
> -    xcb_xkb_logo_doodad_t     *logo; /**<  */
> +    xcb_xkb_logo_doodad_t      logo; /**<  */
>  } xcb_xkb_doodad_t;

Would this change any non-xkb structure in the existing ABI?

- Josh Triplett


More information about the Xcb mailing list