[Xcb] [PATCH:libxcb] Define _xcb_map_new with explicit void arg list instead of empty one

Josh Triplett josh at joshtriplett.org
Sat Aug 3 16:50:16 PDT 2013


On Sat, Aug 03, 2013 at 04:03:05PM -0700, Alan Coopersmith wrote:
> Fixes Solaris Studio compiler warning:
> "xcb_list.c", line 50: warning: old style function definition
> 
> Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>

Reviewed-by: Josh Triplett <josh at joshtriplett.org>

GCC has a warning for this too.  Could you add the appropriate
-Werror=... flag for GCC so this can't happen again?

> ---
>  src/xcb_list.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/xcb_list.c b/src/xcb_list.c
> index 6f5c611..129540b 100644
> --- a/src/xcb_list.c
> +++ b/src/xcb_list.c
> @@ -47,7 +47,7 @@ struct _xcb_map {
>  
>  /* Private interface */
>  
> -_xcb_map *_xcb_map_new()
> +_xcb_map *_xcb_map_new(void)
>  {
>      _xcb_map *list;
>      list = malloc(sizeof(_xcb_map));
> -- 
> 1.7.9.2
> 
> _______________________________________________
> Xcb mailing list
> Xcb at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/xcb


More information about the Xcb mailing list