[Xcb] [Bug 67782] xproto.xml: ConfigureWindow request with additional 'value_mask' field

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=67782

--- Comment #1 from Daniel Martin <consume.noise at gmail.com> ---
(In reply to comment #0)
> Hello,
> 
> In the protocol description for ConfigureWindow there is an extra
> "value_mask" field. This field is not used in the generated
> xcb_configure_window functions.
> 
> Since there is already field called "value_mask" for the valueparam, I
> suspect this is not wanted. This also creates errors when trying to generate
> functions with two "value_mask" parameters.
> 
>   <request name="ConfigureWindow" opcode="12">
>     <pad bytes="1" />
>     <field type="WINDOW" name="window" />
> =>  <field type="CARD16" name="value_mask" />
>     <pad bytes="2" />
>     <valueparam value-mask-type="CARD16"
>                 value-mask-name="value_mask"
>                 value-list-name="value_list" />

This has been done on purpose, see commit b684b0d:
    Re-fix the ConfigureWindow request padding issue.

    We rely on the fact that the valueparam field is treated as a list,
    and, like any other list, the Python code will check if the length
    field is previously defined in the structure before adding a new one.
    This allows us to insert the necessary 2-byte padding.


The best fix would be to replace it with a switch. But, a lot of projects won't
be happy with that:
    http://codesearch.debian.net/search?q=xcb_configure_window


Though, the valueparam can been replaced by a list as in the following
attachment without any drawbacks = without any changes in the generated code.

Replacing valueparams is a good thing, but replacing it with a list is not a
win. So, I don't have any opinion what we should do with that field.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/xcb/attachments/20130805/e9d340ca/attachment.html>