[Xcb] [PATCH] Check for .m4 files before running autoreconf from autogen.sh

[Niclas Zeising]

On 08/12/13 12:05, Arnaud Fontaine wrote:
> Hello,
> 
> Niclas Zeising <zeising at daemonic.se> writes:
> 
>> Attached patch adds a check for autogen.sh that checks for
>> m4/xcb_util_common.m4 before continuing with autoreconf.  Without that
>> .m4 file autoreconf will throw a number of unhelpful error messages.
>> Now autogen.sh will print a message and exiting early instead.  This
>> patch applies to
>> xcb/util
>> xcb/util-cursor
>> xcb/util-image
>> xcb/util-renderutil
>> xcb/util-wm
> 
> It seems that util-keysyms autogen.sh is already trying to fix this
> issue but it should also fail if m4/xcb_util_common.m4 does not
> exist. Could you please merge your patch and what already exists in
> util-keysyms autogen.sh? Thanks!
> 
> Cheers,
> 

I was not aware of that.  I reworked the patch to use the same way as in
util-keysyms instead.  I don't know which way is actually best, but this
way it is consistent.
The patch applies to the same list of modules as before.
Regards!
-- 
Niclas Zeising
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Check-submodules-before-running-autoconf.patch
Type: text/x-diff
Size: 1375 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/xcb/attachments/20130812/4eb68406/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 834 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freedesktop.org/archives/xcb/attachments/20130812/4eb68406/attachment.pgp>