[Xcb] [PATCH] silence some compiler warnings in xcb/util-cursor

Niclas Zeising zeising at daemonic.se
Wed Aug 28 04:07:05 PDT 2013


On 08/18/13 19:14, Michael Stapelberg wrote:
> Hi Niclas,
> 
> Sorry for the late reply, I was at DebConf and rather busy.

No worries, I hope you had a good time at DebConf!
I've been busy myself, hence the late reply.  Sorry for that.

> 
> Niclas Zeising <zeising at daemonic.se> writes:
>> The issue is that in "cursor.h" you have:
>>
>> typedef struct xcb_cursor_context_t { ... };
>>                                           ^
>> Which is missing a typedef name.  However, in "xcb_cursor.h" there is
>> already a typedef struct xcb_cursor_context_t xcb_cursor_context_t;.
>> "xcb_cursor.h" is included in "cursor.h" so the typedef already exists,
>> and there is no need to redo it at all in "cursor.h".  All you need to
>> do there is define the struct.
> Thanks for the explanation. I committed this:
> 
> http://cgit.freedesktop.org/xcb/util-cursor/commit/?id=9a30b01e
> 
> Is the code now in a shape that is fit for release from your FreeBSD
> point of view?
> 

I just tested, and it builds fine on FreeBSD without any additional
patches.  Thanks for your help!
Regards!
-- 
Niclas Zeising

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 834 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freedesktop.org/archives/xcb/attachments/20130828/c2973028/attachment.pgp>


More information about the Xcb mailing list