[Xcb] [PATCH libxcb 0/6] Autoconf: apply X.Org default configuration to XCB

Josh Triplett josh at joshtriplett.org
Tue Dec 3 09:07:12 PST 2013


On Tue, Dec 03, 2013 at 11:12:02AM -0500, Gaetan Nadon wrote:
> XCB has been part of X.Org for a while now. This patch will harmonize the XCB
> configuration, using xorg-macros series of macros. It is already used in the
> XCB utils packages and is needed to build xcb-proto.
> 
> The main changes are the use of the C99 standard and the xorg warning flags.
> Xorg was missing -fd for SUNCC so it has been added to util-macros v 1.18.
> Xorg also added the check for the DOT graphics tool which will be available
> to all other xorg modules as well.
> 
> In m4/xcb.m4, the check for visibility does not cover the Sun compiler which
> has -xldscope=hidden. This has been left as it is.
> 
> *** Requires util-macros version 1.18.0 published Dec 3rd.
> 
> Gaetan Nadon (6):
>   autoconf: use XORG_DEFAULT_OPTIONS
>   autoconf: use the warning variables from xorg
>   autoconf: AC_INIT: add bug url
>   autoconf: comment and layout the initialization section
>   autoconf: require libtool minimum level 2.2
>   autoconf: fix warning by replacing deprecated AC_HELP_STRING

I replied to patch 3 with a minor nit; for the rest (and for 3 with that
issue fixed):
Reviewed-by: Josh Triplett <josh at joshtriplett.org>


More information about the Xcb mailing list