[Xcb] [PATCH] Don't set full sequence for ge events

Daniel Martin consume.noise at gmail.com
Fri Feb 22 08:15:37 PST 2013


On Fri, Feb 22, 2013 at 07:54:25AM -0500, Peter Harris wrote:
> On Fri, Feb 22, 2013 at 3:08 AM, Daniel Martin wrote:
> > In theory, this is an ABI change, in practice no one (no xml
> > implementation in xcb/proto) used those XGE events before.
> 
> There are users of the struct anyway. In particular, this change breaks Xlib:
> 
> http://codesearch.debian.net/search?q=xcb_ge_event_t

Damn, someones using it!

> That's not a show-stopper. Given that the first thing every user does
> is memmove the full_sequence out, or the equivalent, I'd say it's a
> good thing. But we have to be careful to bump an ABI version in the
> autofoo.

Okay, if we would do this change, would it be possible to break even
more? I'm thinking of this bug:
    https://bugs.freedesktop.org/show_bug.cgi?id=6105
where Jamey gave additional comments:
    http://lists.freedesktop.org/archives/xcb/2013-February/008172.html
Then we could simplify a few things.

If that would realy be possible I will sum up what I would like to do,
i.e. change
    xcb_poll_for_event(xcb_connection_t *c)
to
    xcb_poll_for_event(xcb_connection_t *c, unsigned long *sequence)
(or directly with uint64_t).


Cheers,
    Daniel


More information about the Xcb mailing list