[Xcb] [PATCH proto 2/2] xkb: Fix key type map entry field order

Peter Harris pharris at opentext.com
Tue Jul 23 06:40:09 PDT 2013


On 2013-07-23 06:33, Ran Benita wrote:
> In fact, unlike the deleted comment says, both Xlib and the server use
> the order as specified in the protocol spec:
> http://www.x.org/releases/current/doc/kbproto/xkbproto.html#appD::Requests
> (Search for KB_KTMAPENTRY).
> 
> Also see struct xkbKTMapEntryWireDesc in
> /usr/include/X11/extensions/XKBproto.h

Added in
http://cgit.freedesktop.org/xcb/proto/commit/?id=76ca2c0b1527541be59c344118c538ba055ad9d8

I'm guessing the original author was confused by XkbKTMapEntryRec in
/usr/include/X11/extensions/XKBstr.h

Once again, Xlib's propensity for API structures that don't match the
wire structures causes confusion.

Reviewed-by: Peter Harris <pharris at opentext.com>

Peter Harris
-- 
               Open Text Connectivity Solutions Group
Peter Harris                    http://connectivity.opentext.com/
Research and Development        Phone: +1 905 762 6001
pharris at opentext.com            Toll Free: 1 877 359 4866


More information about the Xcb mailing list