[Xcb] Add X Generic Extension event support

Keith Packard keithp at keithp.com
Sat Jun 8 11:38:32 PDT 2013


Daniel Martin <consume.noise at gmail.com> writes:

> Hi everyone,
>
> fixing the full_sequence problem from the ground up would have been a
> nice thing. But, I got conviced that this is a way we can't go without
> causing a lot of trouble. So, we've to deal with it and that's what
> these two patches do.
>
> The first one is for the proto. It introduces a new boolean attribute
> "xge" to events. If it's set to "true", then xcbgen generates the XGE
> event header:
>     [PATCH proto] Add support for X Generic Extension events
>
> The second for the lib injects the full_sequence into XGE events at the
> 32byte boundary. That wouldn't be necessary for XGE events <= 32bytes,
> but it'll be injected in every XGE event for convenience:
>     [PATCH libxcb] c_client.py: Inject full_sequence into GE events

This looks reasonable to me; the only (minor) concern I have is that
this defines the XGE fields with fixed names, which could be different
From some existing XGE definition. I think that's OK though; if there
were any, they'd use the old event definition mechanism which would
still do the right thing.

Oh, I discovered another use for the 'xge' info -- that should suppress
the header file definition of the 'event type'.

Reviewed-by: Keith Packard <keithp at keithp.com>

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 827 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/xcb/attachments/20130608/c8c45053/attachment.pgp>


More information about the Xcb mailing list