[Xcb] [PATCH] sync: Change value list param of CreateAlarm and ChangeAlarm into switch

Daniel Martin consume.noise at gmail.com
Thu Jun 27 14:20:51 PDT 2013


On Thu, Jun 27, 2013 at 02:41:04PM -0400, Peter Harris wrote:
> On Fri, Jun 21, 2013 at 9:13 AM, Louis-Francis Ratté-Boulianne wrote:
> > Values for "Value" and "Delta" fields are 64-bit that couldn't be passed through a regular value list/mask.
> >
> > It does break the API, but CreateAlarm and ChangeAlarm are unusable without that change.
> 
> I'm a huge fan of replacing valueparam with switch. Thanks for the
> patch. It needs a few tweaks to work with both LSB and MSB,
> unfortunately:
> 
> > +      <bitcase>
> > +        <enumref ref="CA">Value</enumref>
> > +        <field type="INT64" name="value" />
> > +      </bitcase>
> 
> It's actually
>         <field type="INT32" name="value_high" />
>         <field type="CARD32" name="value_low" />

For proper confusion there's a struct INT64 defined in this extension,
which has both fields (hi and lo). ;)


More information about the Xcb mailing list