[Xcb] [PATCH proto 7/7] res: Add ClientIdMask enum

Peter Harris pharris at opentext.com
Thu May 30 09:05:50 PDT 2013


On 2013-05-27 13:20, Daniel Martin wrote:
> And make use of it in ClientIdSpec.

>      <!-- v1.2 -->
> +    <enum name="ClientIdMask">
> +        <item name="ClientXID">      <value>1</value> </item>
> +        <item name="LocalClientPID"> <value>2</value> </item>
> +    </enum>
> +
>      <struct name="ClientIdSpec">
>          <field type="CARD32" name="client" />
> -        <field type="CARD32" name="mask" />
> +        <field type="CARD32" name="mask" mask="ClientIdMask" />
>      </struct>

ClientIdMask should probably contain <bit>0</bit> and <bit>1</bit> if it
is going to be used as a mask. The end values are the same, but <bit> is
a better hint (and much easier to maintain as the number of bits climbs).

Peter Harris
-- 
               Open Text Connectivity Solutions Group
Peter Harris                    http://connectivity.opentext.com/
Research and Development        Phone: +1 905 762 6001
pharris at opentext.com            Toll Free: 1 877 359 4866


More information about the Xcb mailing list