[Xcb] Next Release?

[Arnaud Fontaine]

Hi,

Sorry for the lag, I have been rather busy lately.

Daniel Martin <consume.noise at gmail.com> writes:
> On Fri, Oct 11, 2013 at 06:39:27PM +0900, Arnaud Fontaine wrote:
>
> Due to (personal) distractions I'm unable to make it usable anytime
> soon. Sorry for that.
>
> But, I sat down and had a look at that patches and had a look if we
> can get rid of "xkb: Comment out Doodads" with the patch attached to bug
> #68387 "xinput2 XIQueryDevice reply not read correctly".
> While doing so I've found more issues in the generated xkb code. Those
> issues seem to be a real show stoper, which we can't comment out that
> easily. More on this at the bottom.

No problem about that. Thanks for the nice explanation BTW. So, instead
I will merge the related set of 7 patches you submitted to the list on
13th of October and which were reviewed by Ran, right?

>> Therefore I have not merged the following patches:
>> 
>> * [Bug 68387] New: xinput2 XIQueryDevice reply not read correctly
>>   https://bugs.freedesktop.org/show_bug.cgi?id=68387
>
> This seem to be the right thing. As Ran mentioned in the bug the size of
> lists is correct afterwards. Unit tests for other lists might be nice.

Well, there is no commit message on the attached patch. Could you please
add one?

>> * [PATCH proto 1/3] xkb: Comment out Doodads
>>   http://lists.freedesktop.org/archives/xcb/2013-August/008539.html
>>   => Reviewed-By: Ran Benita <ran234 at gmail.com>
>> 
>>   * [PATCH proto 3/3] xkb: Unify events into single event
>>     http://lists.freedesktop.org/archives/xcb/2013-August/008541.html
>>     => Tested-By: Ran Benita <ran234 at gmail.com>
>
> I don't like the patch. If we add it know we'll have an API break when
> replacing the union with a switch/case. Which we can't do atm. due to my
> fault.
>
> Would it be an option to have a planned "break a lot of things - 2.0"
> release? There're other things that could be changed even atm., i.e. the
> valueparams in xproto usually could've been switch/bitcases.

As Julien pointed out, a bump of SONAME should be enough IMO.

>> * [PATCH 1/1] XKB: Fix values of AXFBOpt enum
>>   http://lists.freedesktop.org/archives/xcb/2013-September/008668.html
>>   => Reviewed-By: Ran Benita <ran234 at gmail.com>
>> 
>>   * [Xcb] [PATCH 2/1] XKB: Rewrite AXOption
>>     http://lists.freedesktop.org/archives/xcb/2013-September/008669.html
>>     => Reviewed-By: Ran Benita <ran234 at gmail.com>
>
> Those 2 patches can be merged too.

Merged, thanks.

Cheers,
-- 
Arnaud Fontaine