[Xcb] [PATCH RESEND image 12/12] test: use automake general variables rather than the specific ones

Josh Triplett josh at joshtriplett.org
Thu Mar 27 17:47:49 PDT 2014


On Thu, Mar 27, 2014 at 07:55:08PM -0400, Gaetan Nadon wrote:
> On 14-03-27 03:23 PM, Josh Triplett wrote:
> > This mostly seems fine, but the changes regarding test.xbm seem odd.
> > Could you clarify there why it's OK to leave it out?
> It is odd. The goal is to be able to add many short test programs simply
> by adding the name to noinst_PROGRAMS. The file test.xbm is like a
> header file which normally we put in _SOURCES. In this case we want to
> avoid having to define many _SOURCES variables and the header file must
> be distributed. So EXTRA_DIST does the job.
> 
> Automake:
> 
>     "Header files listed in a |_SOURCES|definition will be included in
>     the distribution but otherwise ignored".

Makes sense.  Can you please make that clear in the commit message, and
perhaps make the change moving test.xbm to EXTRA_DIST in a separate
commit for clarity?

- Josh Triplett


More information about the Xcb mailing list