[Xcb] [PATCH libxcb 00/18] Small improvements to the generator

Ran Benita ran234 at gmail.com
Sun Oct 12 11:58:02 PDT 2014


Some things I've noticed while reading c_client.py.

There are some trivial conflicts with Christian's patches.

Ran Benita (18):
  c_client.py: remove unneeded call to get_serialize_params()
  c_client.py: simplify maximum expression
  c_client.py: fix pyflakes errors
  c_client.py: use print as a function for python3 compatibility
  c_client.py: use comprehensions instead of map/filter
  c_client.py: fix indentation
  c_client.py: use "foo".join() instead of reduce
  c_client.py: no need to compare bools to True/False
  c_client.py: remove end-of-function comments
  c_client.py: use pattern matching with enumerate()
  c_client.py: don't generate useless empty /** < */ comments
  c_client.py: don't add /* <name> */ before references to 'S'
  c_client.py: use C99 initializers instead of comments
  c_client.py: remove commented debug statements
  c_client.py: simplify _c_reply_has_fds()
  c_client.py: spell out keyword arguments in c_request() for clarity
  c_client.py: remove duplicated `cookie_type` argument for requests
  c_client.py: make condition easier to follow in _c_complex()

 src/c_client.py | 231 +++++++++++++++++++++++---------------------------------
 1 file changed, 94 insertions(+), 137 deletions(-)

-- 
2.1.2



More information about the Xcb mailing list