[Xcb] [PATCH proto 2/2 V2] xinput: rep QueryDeviceState struct InputState: full support

[Christian Linhart]

On 10/21/14 22:01, Ran Benita wrote:
> On Fri, Aug 29, 2014 at 07:35:50PM +0200, Christian Linhart wrote:
[...]
>>      <struct name="ValuatorState">
>>          <field type="CARD8" name="class_id" enum="InputClass" />
>>          <field type="CARD8" name="len" />
>>          <field type="CARD8" name="num_valuators" />
>>          <field type="CARD8" name="mode" mask="ValuatorStateModeMask" />
>> -        <list type="CARD32" name="valuators">
>> +        <list type="INT32" name="valuators">
>>              <fieldref>num_valuators</fieldref>
>>          </list>
>>      </struct>
> 
> Remark/question for the archives: if I get it right, this struct, and
> also KeyState and ButtonState, are not needed anymore, since they are
> inlined into InputState, right? 
Yes, you are right.
They are just kept in there for compatibility reasons 
as we have discussed and decided elsewhere.

> At least the test you posted for this
> request looks like it doesn't use them.
> 
> So if they are really not needed, maybe you can add them to your
> struct-removal TODO (if you haven't already).
Added them now to my TODO.

After we'll have merged all the current pending patches to upstream,
we can add the possibility to mark stuff as deprecated
and then we can mark these structs as deprecated.

BTW, At some point in the future, 
an automatic dead-code analyis tool for xml-xcb would be nice,
so we can detect all the structs, enums, typedefs etc which are not used anymore.

Chris