[Xcb] [PATCH] res: Fix GetClientIds reply size

Ran Benita ran234 at gmail.com
Wed May 25 17:40:09 UTC 2016


On Tue, May 24, 2016 at 05:00:52PM -0400, Peter Harris wrote:
> This diverges from the specification to match the current implementation
> of the server.

Title should say "QueryClientIds".

If it diverges from the spec, it would nice to have a comment saying so,
otherwise someone might come in and "fix" it.

About the patch itself: I had a brief look at the server code, it's
pretty convoluted, but I think it sends a single pid and sets length=4,
otherwise doesn't send anything and sets length=0. So patch looks
correct.

Ran

> ---
>  src/res.xml | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/src/res.xml b/src/res.xml
> index 17e6f83..c7cdf48 100644
> --- a/src/res.xml
> +++ b/src/res.xml
> @@ -55,7 +55,10 @@ authorization from the authors.
>          <field type="ClientIdSpec" name="spec" />
>          <field type="CARD32" name="length" />
>          <list type="CARD32" name="value">
> -            <fieldref>length</fieldref>
> +            <op op="/">
> +                <fieldref>length</fieldref>
> +                <value>4</value>
> +            </op>
>          </list>
>      </struct>
>  
> -- 
> 2.7.4
> 
> _______________________________________________
> Xcb mailing list
> Xcb at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/xcb


More information about the Xcb mailing list