[Xcb] [PATCH libxcb] Check strdup for NULL return value.

Uli Schlachter psychon at znc.in
Sat Apr 1 09:57:50 UTC 2017


Thanks, merged.

On 26.03.2017 15:41, Tobias Stoeckmann wrote:
> _xcb_open does not check strdup's return value for NULL if launchd suport
> was configured.
> 
> Signed-off-by: Tobias Stoeckmann <tobias at stoeckmann.org>
> ---
>  src/xcb_util.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/src/xcb_util.c b/src/xcb_util.c
> index a3357ef..a16270c 100644
> --- a/src/xcb_util.c
> +++ b/src/xcb_util.c
> @@ -265,6 +265,8 @@ static int _xcb_open(const char *host, char *protocol, const int display)
>      struct stat sbuf;
>      if (0 == stat(host, &sbuf)) {
>          file = strdup(host);
> +        if(file == NULL)
> +            return -1;
>          filelen = actual_filelen = strlen(file);
>      } else
>  #endif
> 


-- 
"In the beginning the Universe was created. This has made a lot of
 people very angry and has been widely regarded as a bad move."


More information about the Xcb mailing list