<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 TRANSITIONAL//EN">
<HTML>
<HEAD>
<META HTTP-EQUIV="Content-Type" CONTENT="text/html; CHARSET=UTF-8">
<META NAME="GENERATOR" CONTENT="GtkHTML/3.26.0">
</HEAD>
<BODY>
On Thu, 2011-03-24 at 04:26 +0100, Julien Cristau wrote:<BR>
<BLOCKQUOTE TYPE=CITE>
<TT><FONT COLOR="#737373">> Sounds like a very good idea. Thanks for the patch. However, could you</FONT></TT><BR>
<TT><FONT COLOR="#737373">> please add a variable (such as XCB_UTIL_COMMON_LDFLAGS or whatever)</FONT></TT><BR>
<TT><FONT COLOR="#737373">> within XCB_UTIL_COMMON macro in util-common-m4/xcb_util_common.m4 and</FONT></TT><BR>
<TT><FONT COLOR="#737373">> use it in the Makefile.am's because it's common to all libraries. Thanks</FONT></TT><BR>
<TT><FONT COLOR="#737373">> much.</FONT></TT><BR>
<TT><FONT COLOR="#737373">> </FONT></TT><BR>
<TT><FONT COLOR="#1a1a1a">Sounds like obfuscation to me, but hey...</FONT></TT><BR>
</BLOCKQUOTE>
<BR>
My first impression was that it's a bit overkill. It stems from good intentions,<BR>
but the reader of the makefile will have one more level of indirection<BR>
to find the information. There is a balance between "duplication"<BR>
and ease of use.<BR>
<BR>
I wasn't going to mention it, but now that you did...<BR>
<BR>
One general suggestion I have for the xcb modules is to use the patterns<BR>
found in xorg (where it makes sense). If we find a better idiom, then<BR>
we apply it everywhere. We get both consistency and continuous improvement.
</BODY>
</HTML>