<html> <head> <base href="https://bugs.freedesktop.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW --- - xinput2 XIQueryDevice reply not read correctly" href="https://bugs.freedesktop.org/show_bug.cgi?id=68387#c3">Comment # 3</a> on <a class="bz_bug_link bz_status_NEW " title="NEW --- - xinput2 XIQueryDevice reply not read correctly" href="https://bugs.freedesktop.org/show_bug.cgi?id=68387">bug 68387</a> from <a class="email" href="mailto:ran234@gmail.com" title="Ran Benita <ran234@gmail.com>"> Ran Benita</a> <pre>Thanks for the patch Daniel. So it seems this bug is pretty far-reaching; basically all of the _sizeof() functions have it, though it only manifests on the ones which actually use xcb_tmp for anything. So to see the affected functions, you can grep for the pattern "(xcb_tmp)". Most of them are _sizeof()'s of requests/events/errors, which no one cares about I think. But some are used in iterators for _next() functions. The most affected extensions are xkb and xinput, but also others. For example, I'm pretty sure xcb_get_setup() is broken when there is more than one Screen (roots_len > 1) - in this case the attached program should show garbage. So, if you submit the patch with some commit message, Tested-By: Ran Benita <<a href="mailto:ran234@gmail.com">ran234@gmail.com</a>> Reviewed-By: Ran Benita <<a href="mailto:ran234@gmail.com">ran234@gmail.com</a>> As the fix seems pretty obvious, fixes this test and doesn't cause any other problems that I've seen. And I also think this is ample demonstration that no one is using the _sizeof() functions directly, and that they should therefore be static in the c files and not exposed in the headers; I also think this will reduce the extension library sizes substantially due to dead code elimination.</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the QA Contact for the bug.</li> <li>You are the assignee for the bug.</li> </ul> </body> </html>