<html> <head> <base href="https://bugs.freedesktop.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW --- - xcb-util-cursor trying to create Pixmap of size 0" href="https://bugs.freedesktop.org/show_bug.cgi?id=71060#c8">Comment # 8</a> on <a class="bz_bug_link bz_status_NEW " title="NEW --- - xcb-util-cursor trying to create Pixmap of size 0" href="https://bugs.freedesktop.org/show_bug.cgi?id=71060">bug 71060</a> from <a class="email" href="mailto:psychon@znc.in" title="Uli Schlachter <psychon@znc.in>"> Uli Schlachter</a> <pre>Created <a href="attachment.cgi?id=88788" name="attach_88788" title="Check that malloc() succeeds">attachment 88788</a> <a href="attachment.cgi?id=88788&action=edit" title="Check that malloc() succeeds">[details]</a> <a href='page.cgi?id=splinter.html&bug=71060&attachment=88788'>[review]</a> Check that malloc() succeeds The error messages from valgrind don't make much sense to me. That sounds like a broken stack pointer which shouldn't really be possible. However, the other error messages sound like the stack was smashed and everything went downhill. Perhaps compiling with -fstack-protector-all can help narrowing this down... Anyway, the message about read() made me wonder about short reads, thus my first patch adds error checking to all calls to read(). This second patch now also checks the result of malloc() (all calloc() calls are already checked). Also, I kept a tradition alive: Every time I look at xcb-util-cursor, I find memory leaks. See the comments in the patches. @ludovic: Could you test if one of these two patches helps your problem or if I am just finding random issues? Also, perhaps you could run the test program under strace -e trace=file so that we can finally figure out which file contains the broken cursor images.</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the QA Contact for the bug.</li> <li>You are the assignee for the bug.</li> </ul> </body> </html>