<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:ran234@gmail.com" title="Ran Benita <ran234@gmail.com>"> <span class="fn">Ran Benita</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW --- - xinput2 XIQueryDevice reply not read correctly"
href="https://bugs.freedesktop.org/show_bug.cgi?id=68387">bug 68387</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #84415 is obsolete</td>
<td>
</td>
<td>1
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW --- - xinput2 XIQueryDevice reply not read correctly"
href="https://bugs.freedesktop.org/show_bug.cgi?id=68387#c7">Comment # 7</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW --- - xinput2 XIQueryDevice reply not read correctly"
href="https://bugs.freedesktop.org/show_bug.cgi?id=68387">bug 68387</a>
from <span class="vcard"><a class="email" href="mailto:ran234@gmail.com" title="Ran Benita <ran234@gmail.com>"> <span class="fn">Ran Benita</span></a>
</span></b>
<pre>Created <span class=""><a href="attachment.cgi?id=89413" name="attach_89413" title="reset xcb_block_len (with commit message)">attachment 89413</a> <a href="attachment.cgi?id=89413&action=edit" title="reset xcb_block_len (with commit message)">[details]</a></span> <a href='page.cgi?id=splinter.html&bug=68387&attachment=89413'>[review]</a>
reset xcb_block_len (with commit message)
Attached Daniel's patch with a commit message (adapted from the bug).
The diff on the generated code shows some 364 locations where the two lines are
added, all of them _sizeof() functions. Most _sizeof() are not used neither
internally for iterators nor externally (I've never seen them used anywhere),
so could have been broken silently for years. Out of the ones used for
iterators, I believe there are two situations:
- The changes have no semantic change, as in the screens example (see above
comment); it just splits a big "block" to two, having the same end result.
- It fixes a real bug rendering the iterators usable, like in xinput2 and xkb
(the previously attached test crashes without, works with).
The diff is too large for me to inspect every change manually, but I did look
at some random sample. I also tried the patched libxcb with some qt5
applications, and there weren't any problems. So I think the patch should go
in.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the QA Contact for the bug.</li>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>