<html> <head> <meta content="text/html; charset=ISO-8859-1" http-equiv="Content-Type"> </head> <body bgcolor="#FFFFFF" text="#000000"> <div class="moz-cite-prefix">On 14-03-24 09:55 AM, Josh Triplett wrote: </div> <blockquote cite="mid:20140324135533.GA19980@leaf" type="cite"> <pre wrap="">Could you also provide a patch fixing the bug you mention in your commit message, that an --enable-dri3 gets silently ignored if !sendfds? </pre> </blockquote> Sure. Here's the spec, to make sure I understand. <blockquote><tt>User input: sendfds state Result:</tt><tt> </tt><tt>-----------------------------------------------------------------------------</tt><tt> </tt><tt> <nothing> sendfds=yes DRI3 is enabled</tt><tt> </tt><tt> <nothing> sendfds=no DRI3 is disabled</tt><tt> </tt><tt> --enable-dri3=auto sendfds=yes DRI3 is enabled</tt><tt> </tt><tt> --enable-dri3=auto sendfds=no DRI3 is disabled</tt><tt> </tt><tt> </tt><tt> --enable-dri3 sendfds=yes DRI3 is enabled</tt><tt> </tt><tt> --enable-dri3 sendfds=no Error Msg Configuration ABORTS</tt><tt> </tt><tt> --enable-dri3=yes sendfds=yes DRI3 is enabled</tt><tt> </tt><tt> --enable-dri3=yes sendfds=no Error Msg Configuration ABORTS</tt><tt> </tt><tt> </tt><tt> --enable-dri3=no sendfds=yes DRI3 is disabled</tt><tt> </tt><tt> --enable-dri3=no sendfds=no DRI3 is disabled</tt><tt> </tt><tt> --disable-dri3 sendfds=yes DRI3 is disabled</tt><tt> </tt><tt> --disable-dri3 sendfds=no DRI3 is disabled</tt><tt> </tt><tt> </tt><tt>User input "<nothing>" and "--enable-dri3=auto" have the same automake semantic</tt><tt> </tt><tt>User input "--enable-dri3" and "--enable-dri3=yes" have the same </tt><tt><tt>automake </tt>semantic</tt><tt> </tt><tt>User input "--enable-dri3=no" and "--disable-dri3" have the same </tt><tt><tt>automake </tt>semantic</tt><tt> </tt><tt> </tt><tt>Additional problem</tt><tt> </tt><tt>-----------------</tt><tt> </tt><tt>There is a flaw in the current code. If user input is "--enable-sendfds"</tt><tt> </tt><tt>or "--enable-sendfds=yes", it is taken at face value and the presence of the </tt><tt> </tt><tt>required library is not checked.</tt><tt>(See AC_SEARCH_LIBS line 98). </tt><tt> </tt><tt>Clarifying --enable-sendfds option</tt><tt> </tt><tt>-------------------------</tt><tt>--------- </tt><tt>If sendmsg is only used for dri3, perhaps the --enable-sendfds option is redundant.</tt><tt> </tt><tt>Would a builder configure libxcb with --enable-dri3 and --disable-sendfds?</tt><tt> </tt><tt>Or --disable-dri3 and --enable-sendfds together?</tt><tt> </tt><tt> </tt><tt>If sendfds is used for other purposes than dri3 (now or in the future), then it is ok.</tt><tt> </tt></blockquote> </body> </html>