<html> <head> <meta content="text/html; charset=ISO-8859-1" http-equiv="Content-Type"> </head> <body bgcolor="#FFFFFF" text="#000000"> <div class="moz-cite-prefix">On 14-03-27 03:22 PM, Josh Triplett wrote: </div> <blockquote cite="mid:20140327192201.GI8791@jtriplet-mobl1" type="cite"> <pre wrap="">"one target in this directory" does not seem accurate in this case.</pre> </blockquote> Indeed. Multiple targets, but only one source per target with same C Flags unless... point below: <blockquote cite="mid:20140327192201.GI8791@jtriplet-mobl1" type="cite"> <pre wrap=""> Also, test_formats_CPPFLAGS had $(XPROTO_CFLAGS), which got lost in the move to AM_CPPFLAGS. </pre> </blockquote> Nice catch. Other util repos used to depend on X11 protocol in the past. They had removed this dependency from configure.ac but had left this undefined variable in the Makefiles. I got in the habit of removing it (and this time without realizing it). However, I noticed that the test subdir does not #include any X11 protocol. Should it remain removed? The image subdir does #include <X11/Xfuncproto.h>., but only for _X_INLINE. I thought XCB would be independent of X protocols. If I replace the includes with the following code from Xfuncproto.h in xcb_bitops.h, then the compilation is successful: <blockquote><tt>/* C99 keyword "inline" or equivalent extensions in pre-C99 compilers */</tt><tt> </tt><tt>/* requires xproto >= 7.0.9</tt><tt> </tt><tt> (introduced in 7.0.8 but didn't support all compilers until 7.0.9) */</tt><tt> </tt><tt>#if defined(inline) /* assume autoconf set it correctly */ || \</tt><tt> </tt><tt> (defined(__STDC_VERSION__) && (__STDC_VERSION__ - 0 >= 199901L)) /* C99 */ || \</tt><tt> </tt><tt> (defined(__SUNPRO_C) && (__SUNPRO_C >= 0x550))</tt><tt> </tt><tt># define _X_INLINE inline</tt><tt> </tt><tt>#elif defined(__GNUC__) && !defined(__STRICT_ANSI__) /* gcc w/C89+extensions */</tt><tt> </tt><tt># define _X_INLINE __inline__</tt><tt> </tt><tt>#else</tt><tt> </tt><tt># define _X_INLINE</tt><tt> </tt><tt>#endif</tt><tt> </tt></blockquote> It'd be nice to completely remove X11 proto from the picture. It's a nice trade-off between unwanted dependencies and code reuse... We now require C99 for all of xorg. Hmmmm... </body> </html>