<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">Hi Jaya,<br>
<br>
Thank you for your patch.<br>
Adding "_c_accessors(self, name, name)" does the trick.<br>
I have checked the diff of the generated code:<br>
It does only add generated code. No existing generated code is
removed.<br>
Therefore this change is good. Well done!<br>
<br>
Other than that, your patch is malformed:<br>
* It does not apply cleanly with "git am". <br>
The patch looks like it is edited/created by hand instead of
created with "git format-patch".<br>
<br>
* The "+" before "_c_request_helper(self, name,
'xcb_void_cookie_t', True, True, True)" should not be there.<br>
This line already exists.<br>
<br>
Can you please create a well-formed patch and post it here?<br>
( ideally relative to git.demorecorder.com because I'll merge that
to upstream as soon as I get the issues with my new fd.o-account
resolved.)<br>
<br>
Regards,<br>
<br>
Chris<br>
<br>
<br>
On 01/22/15 18:16, Jaya Tiwari wrote:<br>
</div>
<blockquote
cite="mid:CAGt7qzVObxwGgNNRfWn8454RgowL-snMfz0TTt-2yH2i+kmTYw@mail.gmail.com"
type="cite">
<div dir="ltr">Added accessor functions for requests the same way
they were added for structs,events and replies.<br>
Lists for replies have accessor functions now.<br>
<br>
Signed-off-by: Jaya Tiwari <<a moz-do-not-send="true"
href="mailto:tiwari.jaya18@gmail.com" target="_blank">tiwari.jaya18@gmail.com</a>><br>
---<br>
src/c_client.py | 444
++++++++++++++++++++++++++++++++++++++++++++++++--------<br>
1 file changed, 386 insertions(+), 58 deletions(-)<br>
<br>
diff --git a/src/c_client.py b/src/c_client.py<br>
index 56a1766..8a2900c 100644<br>
--- a/src/c_client.py<br>
+++ b/src/c_client.py<br>
<br>
@@ -3136,6 +3136,8 @@ def c_request(self, name):<br>
_c_request_helper(self, name, 'xcb_void_cookie_t',
True, True)<br>
if self.c_need_aux:<br>
_c_request_helper(self, name, 'xcb_void_cookie_t',
True, False, True)<br>
+ _c_request_helper(self, name, 'xcb_void_cookie_t',
True, True, True)<br>
+ _c_accessors(self, name, name)<br>
<br>
# We generate the manpage afterwards because _c_type_setup
has been called.<br>
# TODO: what about aux helpers?<br>
<br clear="all">
<br>
-- <br>
<div>
<div dir="ltr">
<div>Regards,<br>
</div>
Jaya<br>
</div>
</div>
</div>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
Xcb mailing list
<a class="moz-txt-link-abbreviated" href="mailto:Xcb@lists.freedesktop.org">Xcb@lists.freedesktop.org</a>
<a class="moz-txt-link-freetext" href="http://lists.freedesktop.org/mailman/listinfo/xcb">http://lists.freedesktop.org/mailman/listinfo/xcb</a></pre>
</blockquote>
<br>
</body>
</html>