<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:psychon@znc.in" title="Uli Schlachter <psychon@znc.in>"> <span class="fn">Uli Schlachter</span></a>
</span> changed
<a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - util-errors: out of tree builds do not work"
href="https://bugs.freedesktop.org/show_bug.cgi?id=90328">bug 90328</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Status</td>
<td>NEW
</td>
<td>RESOLVED
</td>
</tr>
<tr>
<td style="text-align:right;">Resolution</td>
<td>---
</td>
<td>FIXED
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - util-errors: out of tree builds do not work"
href="https://bugs.freedesktop.org/show_bug.cgi?id=90328#c1">Comment # 1</a>
on <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - util-errors: out of tree builds do not work"
href="https://bugs.freedesktop.org/show_bug.cgi?id=90328">bug 90328</a>
from <span class="vcard"><a class="email" href="mailto:psychon@znc.in" title="Uli Schlachter <psychon@znc.in>"> <span class="fn">Uli Schlachter</span></a>
</span></b>
<pre>commit 5d660ebe872cadcdc85de9d6f9afe05de629c030
Author: Uli Schlachter <<a href="mailto:psychon@znc.in">psychon@znc.in</a>>
Date: Wed May 6 08:10:53 2015 +0200
Do not distribute extensions.c and fix out-of-tree builds
It all started with src/extensions.c being distributed. Thanks to this,
tarballs
shipped with this generated file and actually building this file was
skipped.
Fix this by using the nodist_ variant of the SOURCES variable.
Due to this oversight (sorry!), the out-of-tree build wasn't actually
tested.
The rule that generates src/extensions.c was missing $(srcdir) in front of
the
path to extensions.py. This rule is now fixed and, as suggested by Daphne
Pfister, also changed to explicitly call the python interpreter. Configure
is
changed to look for it.
Finally, extensions.c couldn't include errors.h. This worked before,
because the
C compiler automatically looks for headers in the same directory as the
source
file. However, for out-of-tree builds, the source directory and build
directory
are different. Paper over this problem by explicitly making it look in the
right
directory.
Fixes: <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - util-errors: out of tree builds do not work"
href="show_bug.cgi?id=90328">https://bugs.freedesktop.org/show_bug.cgi?id=90328</a>
Signed-off-by: Uli Schlachter <<a href="mailto:psychon@znc.in">psychon@znc.in</a>></pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the QA Contact for the bug.</li>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>