<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">Hi Alessandro,<br>
<br>
Thank you for this patch. <br>
The upcoming auto-align-check would not have found it because
missing pads would not cause any primitive data-types larger than
8bits to be misaligned.<br>
<br>
I have two requests for getting this patch to the official repo:<br>
1. Can you please repost it in the usual format of posting
patches:<br>
I.e., generated by "git format-patch", <br>
so that the subjectline of the mail is prefixed with [PATCH
proto],<br>
and so that the patch is included in the main message.<br>
<br>
This helps the people on the mailinglist to easily recognize
your post as a patch to be reviewed.<br>
<br>
2. Can you please include an explanation,<br>
and a link to the spec or source code which shows <br>
that these fields really should be 4-byte aligned?<br>
<br>
If you need help with any of these, please tell me.<br>
<br>
Cheers,<br>
<br>
Chris<br>
<br>
<br>
On 08/31/15 14:17, Alessandro Arzilli wrote:<br>
</div>
<blockquote cite="mid:55E445C5.8040301@gmail.com" type="cite">Patch
attached.
<br>
<br>
Alessandro Arzilli.
<br>
<br>
On 08/15/2015 10:43 AM, Christian Linhart wrote:
<br>
<blockquote type="cite">Hi Alessandro,
<br>
<br>
You are welcome.
<br>
<br>
Yes, the missing align-pads will be added because I have an
upcoming patch that automatically checks
<br>
for missing align-pads. Therefore, all missing align-pads will
eventually get fixed.
<br>
<br>
However, to be sure, you can post a patch to the
xcb-mailinglist.
<br>
(make sure that your patch applies cleanly with "git am".)
<br>
<br>
Chris
<br>
<br>
<br>
On 08/13/15 19:17, Alessandro Arzilli wrote:
<br>
<blockquote type="cite">Thanks! Are the <pad align="4"/>
tags going to get added to SetupRequest as well?
<br>
<br>
On 08/13/2015 06:24 PM, Christian Linhart wrote:
<br>
<blockquote type="cite">Hi Alessandro,
<br>
<br>
The patch for the problem which you have reported last
September is now pushed to the official repo:
<br>
<a class="moz-txt-link-freetext" href="http://cgit.freedesktop.org/xcb/libxcb/commit/?id=4033d39d4da21842bb1396a419dfc299591c3b1f">http://cgit.freedesktop.org/xcb/libxcb/commit/?id=4033d39d4da21842bb1396a419dfc299591c3b1f</a>
<br>
<br>
Sorry for the long time between posting my patch and pushing
it.
<br>
(Back then I didn't have commit rights, yet. Later I forgot
about that patch.)
<br>
<br>
Thanks again for reporting that problem back then.
<br>
<br>
Cheers,
<br>
<br>
Chris
<br>
<br>
<br>
On 09/19/14 10:45, Christian Linhart wrote:
<br>
<blockquote type="cite">Hi Alessandro,
<br>
<br>
Thank you for checking that. Yes, you have checked out the
correct branch.
<br>
<br>
I'll look into this.
<br>
Maybe it's easy to fix.
<br>
<br>
Chris
<br>
<br>
On 09/19/14 08:57, Alessandro Arzilli wrote:
<br>
<blockquote type="cite">On 09/18/2014 07:27 PM,
<a class="moz-txt-link-abbreviated" href="mailto:chris@demorecorder.com">chris@demorecorder.com</a> wrote:
<br>
<blockquote type="cite">Hello Alessandro,
<br>
<br>
I think we should fix the problem in the generator
with <pad align="4" />.
<br>
<br>
Can you please try if <pad align="4" /> works
with my newest patches which are not yet merged into
upstream?
<br>
<br>
You can get them with
<br>
git clone
<a class="moz-txt-link-freetext" href="http://infra-srv1.demorecorder.com/git/free-sw/xcb/libxcb/">http://infra-srv1.demorecorder.com/git/free-sw/xcb/libxcb/</a>
<br>
git clone
<a class="moz-txt-link-freetext" href="http://infra-srv1.demorecorder.com/git/free-sw/xcb/proto/">http://infra-srv1.demorecorder.com/git/free-sw/xcb/proto/</a>
<br>
</blockquote>
I get the same error I got with libxcb-1.11.
<br>
<br>
</blockquote>
[...]
<br>
_______________________________________________
<br>
Xcb mailing list
<br>
<a class="moz-txt-link-abbreviated" href="mailto:Xcb@lists.freedesktop.org">Xcb@lists.freedesktop.org</a>
<br>
<a class="moz-txt-link-freetext" href="http://lists.freedesktop.org/mailman/listinfo/xcb">http://lists.freedesktop.org/mailman/listinfo/xcb</a>
<br>
<br>
</blockquote>
<br>
</blockquote>
<br>
</blockquote>
<br>
</blockquote>
<br>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
Xcb mailing list
<a class="moz-txt-link-abbreviated" href="mailto:Xcb@lists.freedesktop.org">Xcb@lists.freedesktop.org</a>
<a class="moz-txt-link-freetext" href="http://lists.freedesktop.org/mailman/listinfo/xcb">http://lists.freedesktop.org/mailman/listinfo/xcb</a></pre>
</blockquote>
<br>
</body>
</html>