2007/3/13, Fabrice Colin <<a href="mailto:fabrice.colin@gmail.com">fabrice.colin@gmail.com</a>>:<div><span class="gmail_quote"></span><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
On 3/13/07, Mikkel Kamstrup Erlandsen <<a href="mailto:mikkel.kamstrup@gmail.com">mikkel.kamstrup@gmail.com</a>> wrote:<br>> Please give <a href="http://freedesktop.org/wiki/WasabiSearchLive">http://freedesktop.org/wiki/WasabiSearchLive
</a> a<br>> good look before we set this in stone. It is the last call if you have any<br>> objections - I really mean it this time. Anything from critisizing the<br>> fundamental structure down to nitpicking on the session property names is
<br>> welcome.<br>><br>There's a couple of things I am not clear about :<br><br>- "search.blocking : Whether or not calls will block until the<br>requested items are available."<br>Do you really mean this ? Should NewSearch block ad vitam eternam if
<br>there are no<br>results for the given query ? ;-)</blockquote><div><br>Ok , that was a bit unclear :-) What I'm trying to say is:<br><br>"Whether or not the methods GetHits and CountHits will block until the
requested items are available or the entire index has been searched"<br><br> - which is also reflected on the wiki now.<br> </div><br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
- "CountHits (in s search, out i count) Returns the current number of<br>found hits. If<br>search.blocking==true this call blocks until the index has been fully searched."<br>Shouldn't this read "if search.live==false
this call blocks..." ?</blockquote><div><br>No. search.live and search.blocking are not the same. search.live just specifies that the search should "persist" and update the result set via the signals described.
<br><br>search.blocking determines whether or not the calls GetHits and CountHits return immediately with partial results or only when the result is fully available.<br> </div><br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
- "These signals are only used if the session property search.blocking is true."<br>Again, shouldn't it be "if search.live is true" ?</blockquote><div><br>Right. Fixed. <br></div><br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
- GetState<br>if the first string is "FULL_INDEX", shouldn't the second string<br>always be "100" ?</blockquote><div><br>I was a bit in a rusj when I wrote that part... here are better descriptions of the states:
<br><br>IDLE : the search engine is doing nothing<br>UPDATE : the search engine is updating the index<br>FULL_INDEX: the search engine is building an index from scratch<br><br>So, to answer your question - no :-) Wiki updated.
<br></div><br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">- signal HitsAdded<br>is count the number of new hits, or the new number of hits ? I assume the latter
<br>since the example at the bottom shows a call to "GetHits(session, count)" after<br>receiving "HitsAdded(count)".</blockquote><div><br><br>Right. I have tried to clarify this. <br></div><br><br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
- signal StateChanged<br>An example would be welcome here. For indexers that monitor sources, eg monitor<br>the filesystem with inotify, the state will switch between UPDATING<br>and IDLE and/or FULL_INDEX very often. Is the indexer supposed to send
<br>a signal every time ?</blockquote><div><br>True - this is unclear. I've added a note saying that for "negligible" tasks (re-index a single file or such) the signal need not be fired.<br> </div><br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
- properties and field names<br>You may want to clarify what differences, if any, there are between<br>properties and<br>field names.</blockquote><div><br>Yeah, I might have spend too much time fiddling about with this to see where the subtleties are anymore. I have updated the wiki with clarifications. - There where some cruft left from previous iteratiosn that blurred the picture too.
<br><br>I took the liberty to rename the session property hit.properties to hit.fields to make matters more clear. I hope it is ok.<br> </div>I hope it is better now. Please check that I've catered to your remarks.<br>
<br>Cheers,<br>Mikkel<br></div><br>