Hi Richard,<br><br><div><span class="gmail_quote">On 3/21/07, <b class="gmail_sendername">Richard Hughes</b> <<a href="mailto:hughsient@gmail.com">hughsient@gmail.com</a>> wrote:</span><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
On 21/03/07, Alp Toker <<a href="mailto:alp@atoker.com">alp@atoker.com</a>> wrote:<br>> </method><br>> -<br>> <!--<br>> Returns the system AC state, i.e. if we are not running on battery
<br>> power.<br>> Note: This method may still return false on AC using a desktop<br>> system<br>> if the computer is using backup power from a monitored UPS.<br>> --><br>> -
<br>> <method name="GetAcState"><br>> <arg type="b" name="ac_state" direction="out"/><br>> </method><br>><br>> AC (alternating current?) is kind of an implementation detail. I will
<br>> probably just want to know if the device IsOnExternalPower or something.<br>> "AC" means nothing to me as an application developer.<br><br>Valid point. What about IsOnBatteryPower?<br><br>> <!--
<br>> Signals the value of the current brightness has changed.<br>> --><br>> <signal name="BacklightBrightnessChanged"/><br>> <!-- Signals the AC state has changed. --><br>> <signal name="AcStateChanged"/>
<br>> <!-- Signals the low power mode has changed. --><br>> <signal name="LowPowerModeChanged"/><br>> -<br>> <!--<br>> Signals the system state description has changed.<br>
> --><br>> <signal name="DescriptionChanged"/><br>> <!-- Signals the system icon has changed. --><br>> <signal name="IconChanged"/><br><br></blockquote></div><br>Same nit-picky stuff for me - It seems to me that if you are going to change from AC vs. Battery (to abstract the implementation of power), you should better name the methods and signals to "Internal" or "External" or something like this - this will cover any type of battery or external power. There are many data centers that use DC power on rails out to the units so using "AC" for the external power may not be accurate -
i.e. change the signal from AcStateChanged to ExternalPowerStateChanged, and the method for IsOnBatteryPower to IsOnExternalPower... <br><br>My 2 cents..<br>--<br>Matt<br>