[xorg-bugzilla-noise] [Bug 1106] New: Radeon: RENDER accel allocates wrong amount of offscreen video memory

[bugzilla-daemon at freedesktop.org]

Please do not reply to this email: if you want to comment on the bug, go to          
the URL shown below and enter yourcomments there.   
 
https://freedesktop.org/bugzilla/show_bug.cgi?id=1106        
   
           Summary: Radeon: RENDER accel allocates wrong amount of offscreen
                    video memory
           Product: xorg
           Version: CVS_head
          Platform: PC
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Driver/Radeon
        AssignedTo: xorg-bugzilla-noise at freedesktop.org
        ReportedBy: thomas at winischhofer.net


The radeon driver's RENDER acceleration code allocates offscreen memory using
xf86AllocateOffscreenLinear(). However, given the fact that the "size" argument
to that call is supposed to be in units of "pixels" (and thus depending on the
current screen's depth), it does this the wrong way:

Currently, this looks like this:

  tex_bytepp = PICT_FORMAT_BPP(format) >> 3;
  [...]
  dst_pitch = (width * tex_bytepp + 31) & ~31;
  size = dst_pitch * height;

  AllocateLinear(size);  

This is wrong because the result is the size of the texture in bytes, not screen
pixels. The "size" has to be calculated like this (where as bpp =
pScrn->bitsPerPixel >> 3):

  size = ((dst_pitch + bpp - 1) / bpp) * height;        
   
   
--         
Configure bugmail: https://freedesktop.org/bugzilla/userprefs.cgi?tab=email       
   
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.