[xorg-bugzilla-noise] [Bug 1114] New: [PATCH] convert afb and cfb{, 16, 24, 32} to be dlloader-friendly

[bugzilla-daemon at freedesktop.org]

Please do not reply to this email: if you want to comment on the bug, go to          
the URL shown below and enter yourcomments there.   
 
https://freedesktop.org/bugzilla/show_bug.cgi?id=1114        
   
           Summary: [PATCH] convert afb and cfb{,16,24,32} to be dlloader-
                    friendly
           Product: xorg
           Version: CVS_head
          Platform: PC
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Loader / dlloader
        AssignedTo: ajax at nwnk.net
        ReportedBy: ajax at nwnk.net
                CC: xorg-bugzilla-noise at freedesktop.org
OtherBugsDependingO 400
             nThis:


This patch makes afb and the various cfb modules load successfully under
dlloader.  It should not change any runtime behaviour, but I haven't tested it
yet.  With two exceptions, these changes parallel changes in other modules, so
it should be pretty much right.

afb implicitly relied on mfb without ever loading it, and neither the fbdev nor
vesa drivers (the only two users of afb) loaded mfb for it.  I don't see how
this could have ever worked under even the old module loader.  afb now loads mfb
as a submodule.

cfb now has an interesting hack that fixes up some of the GCOps structs
automagically at CreateGC time.  anholt said something suitably scary about not
doing so lazily (ie, when the function to be fixed up was called) due to the
wrapping rules for GCOps, hopefully this is correct.

Please consider this for merging before the release, it would make subffb and
sunleo work at least partially under dlloader.        
   
   
--         
Configure bugmail: https://freedesktop.org/bugzilla/userprefs.cgi?tab=email       
   
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.