[xorg-bugzilla-noise] [Bug 1360] New: xcompmgr doesn't check XQueryTree's return value

[bugzilla-daemon at freedesktop.org]

Please do not reply to this email: if you want to comment on the bug, go to          
the URL shown below and enter yourcomments there.   
 
https://freedesktop.org/bugzilla/show_bug.cgi?id=1360        
   
           Summary: xcompmgr doesn't check XQueryTree's return value
           Product: xapps
           Version: unspecified
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: P2
         Component: xcompmgr
        AssignedTo: xorg-bugzilla-noise at freedesktop.org
        ReportedBy: ion+bugzilla-freedesktop at ion.yi.org


xcompmgr (from CVS) doesn't check XQueryTree's return value. This causes it to 
segfault when starting konqueror: certain XQueryTree calls seem to fail and the 
for loop in determine_wintype() is called with an uninitialized nchildren. 
 
The attached patch seems to fix it for me. 
 
PS. There seems to be also another unchecked XQueryTree call in xcompmgr.c at 
line 1884. This patch does not affect it.        
   
   
--         
Configure bugmail: https://freedesktop.org/bugzilla/userprefs.cgi?tab=email       
   
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.