[xorg-bugzilla-noise] [Bug 1447] New: Accessing freed memory

[bugzilla-daemon at freedesktop.org]

Please do not reply to this email: if you want to comment on the bug, go to          
the URL shown below and enter yourcomments there.   
 
https://freedesktop.org/bugzilla/show_bug.cgi?id=1447        
   
           Summary: Accessing freed memory
           Product: xorg
           Version: CVS_head
          Platform: PC
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Lib/other
        AssignedTo: xorg-bugzilla-noise at freedesktop.org
        ReportedBy: mark at skynet.ie


Library: libSM

The docs for the RegisterClient callback says:

  Call free on the previous_id pointer when it is no longer needed.

However, if the callback returns zero, SmsProcessMessage() still tries to access
previousId even though the callback should have freed it.

Problem shown up by some valgrinding on gnome-session by Kjatan Maraas.

Attaching what I think looks like a reasonable patch.        
   
   
--         
Configure bugmail: https://freedesktop.org/bugzilla/userprefs.cgi?tab=email       
   
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.