CVS Update: xc (branch: XORG-6_8-branch)
Roland Mainz
xorg-commit at cvs.freedesktop.org
Thu Dec 16 03:58:57 EET 2004
CVSROOT: /cvs/xorg
Module name: xc
Changes by: gisburn at gabe.freedesktop.org 04/12/15 17:58:57
Log message:
2004-12-15 Roland Mainz <roland.mainz at nrubsig.org>
* xc/programs/Xserver/hw/xfree86/drivers/ati/radeon_driver.c
Bugzilla #1306 (https://bugs.freedesktop.org/show_bug.cgi?id=1306)
attachment #1292 (https://bugs.freedesktop.org/attachment.cgi?id=1292):
This patch should work around the panel timing params not being initialized.
Here's the problem:
Previously, the PanelXRes and PanelYRes were either read from the BIOS or were
left as 0 (if no BIOS was detected). Then, in RADEONUpdatePanelSize(), the max
panel size was found and the timing parameters were initialized, which worked
fine for this ppc system.
Now, the PanelXRes and PanelYRes are either read from the BIOS or are read from
the registers. Note that the other timing parameters (in particular the
DotClock) are not initialized when reading from the registers. Then, when
RADEONUpdatePanelSize() is called, the max panel size is already set, so none
of the other timing parameters are initialized here either (or anywhere else
for that matter), which appears to be why the new code fails for this ppc
system.
The patch changes the test from < to <= in RADEONUpdatePanelSize() and then
tests to make sure that only the first set of timings for the panel size read
from the registers will be used -- this mimics the way the previous code
worked. The only problem with this code occurs when the registers hold invalid
panel size params, which do not match any of the monitor's DDC info. This
should never happen; however, if it does, then the only solution in this case
is to explicitly set the panel size in the config file.
Patch by Kevin E. Martin <kem at freedesktop.org>
Modified files:
./: Tag: XORG-6_8-branch
ChangeLog
xc/programs/Xserver/hw/xfree86/drivers/ati/: Tag: XORG-6_8-branch
radeon_driver.c
Revision Changes Path
1.365.2.96 +32 -1 xc/ChangeLog
1.19.2.3 +4 -2 xc/programs/Xserver/hw/xfree86/drivers/ati/radeon_driver.c
More information about the xorg-commit
mailing list