libXrandr: Changes to 'master'
Alan Coopersmith
alanc at kemper.freedesktop.org
Fri Jul 5 21:08:24 PDT 2013
src/XrrProvider.c | 11 ++++++++++-
1 file changed, 10 insertions(+), 1 deletion(-)
New commits:
commit 9e4abe746786f0f632d1f82f99fe0c6b8ffedf9e
Author: Alan Coopersmith <alan.coopersmith at oracle.com>
Date: Sun Jun 30 16:52:59 2013 -0700
XRRGetProviderInfo returned bad associated_capability list in 64-bit
Unlike most of the values returned by this function, which are arrays
of XIDs (long int), associated_capability is defined as an array of
unsigned int. _XRead32 reads 32-bit values from the wire protocol
and writes them to the provided buffer as an array of long ints, even
if that means expanding them from 32-bit to 64-bit. Doing that for
associated_capability resulted in a garbage value between each actual
value, and overflowing the provided buffer into the space for the
provider name (which is written later and would overwrite the overflowed
data).
Created xhiv libXrandr/XRRGetProviderInfo test case to test & confirm.
Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>
Reviewed-by: Dave Airlie <airlied at redhat.com>
More information about the xorg-commit
mailing list