xkbcomp: Changes to 'master'
Alan Coopersmith
alanc at kemper.freedesktop.org
Mon Mar 10 23:27:10 PDT 2014
geometry.c | 1 -
keycodes.c | 2 +-
keytypes.c | 2 +-
listing.c | 2 +-
parseutils.c | 6 ++----
5 files changed, 5 insertions(+), 8 deletions(-)
New commits:
commit d4e02a09258063c6d024c3ccd42d6b22212e6e18
Author: Alan Coopersmith <alan.coopersmith at oracle.com>
Date: Sat Mar 8 19:04:24 2014 -0800
Initialize nMatch even if WIN32 is defined
Flagged by cppcheck 1.64:
Checking app/xkbcomp/listing.c: WIN32...
[app/xkbcomp/listing.c:335]: (error) Uninitialized variable: nMatch
Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>
Reviewed-by: Peter Hutterer <peter.hutterer at who-t.net>
Reviewed-by: Daniel Stone <daniel at fooishbar.org>
commit 7606a46b922dfdb0627f1af6ab1432ae88c79d66
Author: Alan Coopersmith <alan.coopersmith at oracle.com>
Date: Sat Mar 8 19:01:12 2014 -0800
Remove useless assignment to 'outline' variable
Flagged by cppcheck 1.64:
[app/xkbcomp/geometry.c:2426] -> [app/xkbcomp/geometry.c:2427]:
(performance) Variable 'outline' is reassigned a value before
the old one has been used.
Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>
Reviewed-by: Peter Hutterer <peter.hutterer at who-t.net>
Reviewed-by: Daniel Stone <daniel at fooishbar.org>
commit 6c2d3b0891f7be6ef4895be75188aa1c6f530bfc
Author: Alan Coopersmith <alan.coopersmith at oracle.com>
Date: Sat Mar 8 18:50:22 2014 -0800
Don't dereference the pointer whose allocation failed
Flagged by cppcheck 1.64:
[app/xkbcomp/keycodes.c:264] -> [app/xkbcomp/keycodes.c:262]:
(warning) Possible null pointer dereference: new - otherwise it
is redundant to check it against null.
[app/xkbcomp/keytypes.c:600] -> [app/xkbcomp/keytypes.c:597]:
(warning) Possible null pointer dereference: old - otherwise it
is redundant to check it against null.
Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>
Reviewed-by: Peter Hutterer <peter.hutterer at who-t.net>
Reviewed-by: Daniel Stone <daniel at fooishbar.org>
commit 50ebe95a32dc59b1de899ef08f72462055b04065
Author: Alan Coopersmith <alan.coopersmith at oracle.com>
Date: Sat Mar 8 18:46:11 2014 -0800
Remove useless checks for NULL before free in OverlayKeyCreate()
There is no need to ensure the pointers passed to free are not NULL,
especially right after passing them to strncpy without checking for
NULL.
Flagged by cppcheck 1.64:
[app/xkbcomp/parseutils.c:557] -> [app/xkbcomp/parseutils.c:559]:
(warning) Possible null pointer dereference: over - otherwise it
is redundant to check it against null.
[app/xkbcomp/parseutils.c:558] -> [app/xkbcomp/parseutils.c:561]:
(warning) Possible null pointer dereference: under - otherwise it
is redundant to check it against null.
Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>
Reviewed-by: Peter Hutterer <peter.hutterer at who-t.net>
Reviewed-by: Daniel Stone <daniel at fooishbar.org>
More information about the xorg-commit
mailing list