libICE: Changes to 'master'
GitLab Mirror
gitlab-mirror at kemper.freedesktop.org
Sat May 7 00:38:33 UTC 2022
configure.ac | 21 +++++++++------------
src/connect.c | 35 ++++++++++++++++++-----------------
src/process.c | 6 +++---
3 files changed, 30 insertions(+), 32 deletions(-)
New commits:
commit 7b439c788b94849d4f07cda77518bec43ebbd9a6
Author: walter harms <wharms at bfs.de>
Date: Thu Sep 7 18:46:39 2017 +0200
connect.c: FIX 'iceConn' shadows a previous local, [-Wshadow]
In function 'IceOpenConnection': gcc give the following warning:
connect.c:106:11: warning: declaration of 'iceConn' shadows a previous local [-Wshadow]
fixed by renaming 2. iceConn to iConn (and all its uses)
Signed-off-by: Walter Harms <wharms at bfs.de>
Reviewed-by: Alan Coopersmith <alan.coopersmith at oracle.com>
commit 348b9a46086ad72d6f29f2637036accff6630db4
Author: Alan Coopersmith <alan.coopersmith at oracle.com>
Date: Sat Apr 30 15:17:40 2022 -0700
ProcessAuthReply: rename status variable to avoid shadowing
Fixes gcc complaint:
process.c: In function ‘ProcessAuthReply’:
process.c:1478:20: warning: declaration of ‘status’ shadows a previous local [-Wshadow]
1478 | Status status = 1;
| ^~~~~~
process.c:1426:25: note: shadowed declaration is here
1426 | IcePaAuthStatus status =
| ^~~~~~
Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>
commit d70c666549a9ee17de7349904529cf41bf023926
Author: Alan Coopersmith <alan.coopersmith at oracle.com>
Date: Sat Apr 30 15:04:53 2022 -0700
ConnectToPeer: be doubly sure that use-after-free doesn't happen
This resolves an issue reported by the Oracle Parfait static analyzer:
Error: Use after free
Use after free [use-after-free] (CWE 416):
Use after free of pointer trans_conn
at line 566 of lib/libICE/src/connect.c in function 'ConnectToPeer'.
trans_conn previously freed with _IceTransClose at line 532
trans_conn was allocated at line 525 with _IceTransOpenCOTSClient
even though I believe this is already handled by the
'if (madeConnection) { ... } else trans_conn = NULL;'
block, but the analyzer apparently doesn't follow that logic,
while this simple change makes it obvious.
Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>
commit 8d2cb9e7a897a070b2509f9de60961c9d154ee99
Author: Alan Coopersmith <alan.coopersmith at oracle.com>
Date: Sat Apr 30 14:39:02 2022 -0700
configure: check for libbsd before libxtrans checks for strlcpy
If we're going to link to libbsd, might as well use it for strlcpy too
Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>
More information about the xorg-commit
mailing list