libXpm: Changes to 'master'

[GitLab Mirror]

 configure.ac   |    2 +-
 src/CrDatFrI.c |    5 +++--
 src/create.c   |    4 ++--
 src/parse.c    |   19 -------------------
 4 files changed, 6 insertions(+), 24 deletions(-)

New commits:
commit 92030dd4c221e8043521ae4dc9d32d50e6ff44c4
Author: Alan Coopersmith <alan.coopersmith at oracle.com>
Date:   Sun Feb 12 13:22:57 2023 -0800

    parse.c: remove unused function xstrlcpy()
    
    parse.c:74:1: warning: unused function 'xstrlcpy' [-Wunused-function]
    xstrlcpy(char *dst, const char *src, size_t dstsize)
    ^
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>

commit 8e0e63519069bed43b3bf1ce1f11fd0cd516d3e4
Author: Alan Coopersmith <alan.coopersmith at oracle.com>
Date:   Sun Feb 12 10:51:46 2023 -0800

    parse.c: Wrap FREE_CIDX definition in do { ... } while(0)
    
    Makes it match the definition in create.c and eliminates
    clang warnings:
    
    create.c:2409:13: warning: empty expression statement has no effect;
     remove unnecessary ';' to silence this warning [-Wextra-semi-stmt]
                            FREE_CIDX;
                                     ^
    create.c:2440:17: warning: empty expression statement has no effect;
     remove unnecessary ';' to silence this warning [-Wextra-semi-stmt]
                                FREE_CIDX;
                                         ^
    create.c:2444:13: warning: empty expression statement has no effect;
     remove unnecessary ';' to silence this warning [-Wextra-semi-stmt]
                            FREE_CIDX;
                                     ^
    create.c:2449:15: warning: empty expression statement has no effect;
     remove unnecessary ';' to silence this warning [-Wextra-semi-stmt]
                FREE_CIDX;
                         ^
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>

commit 25616112983cd3f8bfe5379771b5bfd63b3c3621
Author: Alan Coopersmith <alan.coopersmith at oracle.com>
Date:   Sun Feb 12 09:23:09 2023 -0800

    XpmCreateDataFromXpmImage: Fix misleading indentation
    
    CrDatFrI.c: In function ‘XpmCreateDataFromXpmImage’:
    CrDatFrI.c:245:13: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
      245 |             if (header[l])
          |             ^~
    In file included from CrDatFrI.c:40:
    XpmI.h:80:22: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ‘if’
       80 | #define XpmFree(ptr) free(ptr)
          |                      ^~~~
    CrDatFrI.c:247:17: note: in expansion of macro ‘XpmFree’
      247 |                 XpmFree(header);
          |                 ^~~~~~~
    CrDatFrI.c: In function ‘CreateColors’:
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>

commit 45d8f4f20665c77dd1924b78559fb2494a77ad7a
Author: Alan Coopersmith <alan.coopersmith at oracle.com>
Date:   Sun Feb 12 09:20:44 2023 -0800

    Require LT_INIT from libtool 2 instead of deprecated AC_PROG_LIBTOOL
    
    AC_PROG_LIBTOOL was replaced by LT_INIT in libtool 2 in 2008,
    so it's time to rely on it.
    
    configure.ac:14: warning: The macro `AC_PROG_LIBTOOL' is obsolete.
    configure.ac:14: You should run autoupdate.
    m4/libtool.m4:100: AC_PROG_LIBTOOL is expanded from...
    configure.ac:14: the top level
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>