libX11: Changes to 'master'

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Wed Jan 4 22:43:15 UTC 2023


 src/PutBEvent.c |   15 +--------------
 1 file changed, 1 insertion(+), 14 deletions(-)

New commits:
commit 88399e01be679bfcc9a5e8922ffe2c47f0e56dee
Author: Yuxuan Shui <yshuiv7 at gmail.com>
Date:   Tue Jan 3 15:09:28 2023 +0000

    Revert "Update XPutBackEvent() to support clients that put back unpadded events"
    
    This reverts commit d6d6cba90215d323567fef13d6565756c9956f60.
    
    The reverted commit intended to fix the problem where an unpadded X
    event struct is passed into XPutBackEvent, by creating a padded struct
    with _XEventToWire and _XWireToEvent. However, _XWireToEvent updates the
    last sequence number in Display, which may cause xlib to complain about
    lost sequence numbers.
    
    IMO, the problem that commit tried to solve is a bug in the client
    library, and workaround it inside Xlib is bad practice, especially given
    the problem it caused. Plus, the offender cited in the original commit
    message, freeglut, has already fixed this problem.
    
    Fixes: #176 #174
    
    Signed-off-by: Yuxuan Shui <yshuiv7 at gmail.com>



More information about the xorg-commit mailing list