iceauth: Changes to 'master'

[GitLab Mirror]

 configure.ac |   10 +++++
 iceauth.c    |    7 +---
 process.c    |   99 ++++++++++++++++++++++++++++++++---------------------------
 3 files changed, 65 insertions(+), 51 deletions(-)

New commits:
commit 29e22b4199f3b0fb4044a8026664951e5aab4700
Author: Alan Coopersmith <alan.coopersmith at oracle.com>
Date:   Sat Feb 3 12:12:21 2024 -0800

    Variable scope reductions, as suggested by cppcheck
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>

commit 43da1a3b78fbe0afc5db4a89fa8f72d3b5f7b91a
Author: Alan Coopersmith <alan.coopersmith at oracle.com>
Date:   Sat Feb 3 11:22:53 2024 -0800

    Silence -Wanalyzer-out-of-bounds warnings from gcc 13
    
    Analyzer seems not to realize that the last allocated argv entry
    should always be set to NULL, causing the || to stop checking argv
    entries before getting to any that are not allocated.  Raising our
    minimum allocation from 4 pointers to 6 soothes it, and costs us
    basically nothing.
    
    process.c:1285:26: warning: heap-based buffer over-read [CWE-126] [-Wanalyzer-out-of-bounds]
     1285 |         !argv[3] || !argv[4] || !argv[5])
          |                      ~~~~^~~
    [...]
    process.c:1285:26: note: read of 8 bytes from after the end of the region
     1285 |         !argv[3] || !argv[4] || !argv[5])
          |                      ~~~~^~~
    process.c:1285:38: warning: heap-based buffer over-read [CWE-126] [-Wanalyzer-out-of-bounds]
     1285 |         !argv[3] || !argv[4] || !argv[5])
          |                                  ~~~~^~~
    [...]
    process.c:1285:38: note: read of 8 bytes from after the end of the region
     1285 |         !argv[3] || !argv[4] || !argv[5])
          |                                  ~~~~^~~
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>

commit 16ace290b2e6d261db21b60bf6ab7c074b112569
Author: Alan Coopersmith <alan.coopersmith at oracle.com>
Date:   Sat Feb 3 11:20:19 2024 -0800

    Use reallocarray if available, provide local version if not
    
    Based on similar commits to xauth
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>