[PATCH input-mouse 2/2] config: use AM_CFLAGS as both variables contain C flags

Gaetan Nadon memsize at videotron.ca
Tue Mar 9 16:43:40 PST 2010


On Tue, 2010-03-09 at 14:09 -0800, Alan Coopersmith wrote:

> They're separate there since that was one of the modules I'd actually added
> lint support to, and lint needs the -I/-D flags that are passed in CPPFLAGS,
> but not the -W/-v flags from CWARNFLAGS.
> 
> 	-alan-
> 

I had just glanced over the LINT target, but I'll dig into it. I had
considered separating options between AM_CFLAGS and AM_CPPFLAGS in
modules, but xorg-server from pc file contains -fvisibility=hidden
tangled with includes.

There are 33 modules with a LINT target. I was in the process of
removing the obsolete INCLUDES Automake variable (due to a warning) but
I had not noticed it was used in lint. 

Thanks


> Gaetan Nadon wrote:
> > It's more for consistency with other modules.
> > 
> > Signed-off-by: Gaetan Nadon <memsize at videotron.ca>
> > ---
> >  src/Makefile.am |    3 +--
> >  1 files changed, 1 insertions(+), 2 deletions(-)
> > 
> > diff --git a/src/Makefile.am b/src/Makefile.am
> > index 0857c98..ec18c5c 100644
> > --- a/src/Makefile.am
> > +++ b/src/Makefile.am
> > @@ -18,8 +18,7 @@
> >  #  IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN
> >  #  CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
> >  
> > -AM_CFLAGS = $(CWARNFLAGS) 
> > -AM_CPPFLAGS = $(XORG_CFLAGS)
> > +AM_CFLAGS = $(XORG_CFLAGS) $(CWARNFLAGS)
> >  
> >  # this is obnoxious:
> >  # -module lets us name the module exactly how we want
> 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.x.org/archives/xorg-devel/attachments/20100309/a23b16f1/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part
URL: <http://lists.x.org/archives/xorg-devel/attachments/20100309/a23b16f1/attachment.pgp>


More information about the xorg-devel mailing list