[PATCH]: fix refcounting in xf86_use_hw_cursor

[Michel Dänzer]

On Tue, 2010-03-09 at 18:25 +0100, Roland Scheidegger wrote: 
> This is the same fix as was done in
> fcdc1d78cca3b8bb6b77d53eda7e21d649df6943 for xf86_use_hw_cursor_argb.

Reviewed-by: Michel Dänzer <michel at daenzer.net>

Roland, you need to add Signed-off-by: tags to your patches, or Keith
may just ignore them. (Also consider using git send-email, e.g. I
suspect your author e-mail address should be different)


> diff --git a/hw/xfree86/modes/xf86Cursors.c b/hw/xfree86/modes/xf86Cursors.c
> index 385848b..e2e174e 100644
> --- a/hw/xfree86/modes/xf86Cursors.c
> +++ b/hw/xfree86/modes/xf86Cursors.c
> @@ -461,11 +461,11 @@ xf86_use_hw_cursor (ScreenPtr screen, CursorPtr cursor)
>      xf86CrtcConfigPtr   xf86_config = XF86_CRTC_CONFIG_PTR(scrn);
>      xf86CursorInfoPtr	cursor_info = xf86_config->cursor_info;
>  
> +    ++cursor->refcnt;
>      if (xf86_config->cursor)
>  	FreeCursor (xf86_config->cursor, None);
>      xf86_config->cursor = cursor;
> -    ++cursor->refcnt;
> -    
> +
>      if (cursor->bits->width > cursor_info->MaxWidth ||
>  	cursor->bits->height> cursor_info->MaxHeight)
>  	return FALSE;




-- 
Earthling Michel Dänzer           |                http://www.vmware.com
Libre software enthusiast         |          Debian, X and DRI developer