[PATCH] Remove deprecated "nv" driver from autoconfiguration list

Aaron Plattner aplattner at nvidia.com
Wed Mar 31 16:44:27 PDT 2010


On Wed, Mar 31, 2010 at 01:38:08PM -0700, Alan Coopersmith wrote:
> Nvidia hardware will now default to "vesa" until an xorg.conf file is
> created to set it to "nv", "nvidia", or "nouveau".
> 
> We've had reports of displays that fail to autoconfigure because
> Xorg tries to use "nv", but nv fails when DisplayPort is in use.
> 
> Given nvidia's recent announcement deprecating the nv driver,
> and that nv will never support DisplayPort, the vesa driver
> seems a safer default for autoconfiguration than nv.
> 
> Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>
> ---
>  hw/xfree86/common/xf86AutoConfig.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/hw/xfree86/common/xf86AutoConfig.c b/hw/xfree86/common/xf86AutoConfig.c
> index 7b836b0..a6f0c57 100644
> --- a/hw/xfree86/common/xf86AutoConfig.c
> +++ b/hw/xfree86/common/xf86AutoConfig.c
> @@ -192,7 +192,7 @@ videoPtrToDriverList(struct pci_device *dev,
>  	    break;
>  	case 0x102b:		    driverList[0] = "mga";	break;
>  	case 0x10c8:		    driverList[0] = "neomagic"; break;
> -	case 0x10de: case 0x12d2:   driverList[0] = "nv";	break;
> +	case 0x10de: case 0x12d2:   /* nv is deprecated */	break;
>  	case 0x1106:		    driverList[0] = "openchrome"; break;
>          case 0x1b36:		    driverList[0] = "qxl"; break;
>  	case 0x1163:		    driverList[0] = "rendition"; break;
> -- 
> 1.5.6.5

This is an awfully big hammer just to deal with DisplayPort devices, since
the driver still works fine for everybody else.  It would be nice to
instead have the server gracefully fall back when PreInit fails instead of
just bailing out, but I can understand if that's too big of a change to try
to make for 1.8.

If it would help, we could make -nv look for DP devices in PciProbe and
fail if it finds any.

-- Aaron


More information about the xorg-devel mailing list