[PATCH] evdev: handle touchscreens without BTN_TOUCH

Peter Korsgaard jacmet at sunsite.dk
Tue May 24 00:16:22 PDT 2011


>>>>> "Peter" == Peter Hutterer <peter.hutterer at who-t.net> writes:

Hi,

 >> Argh, what then? Check for devices with abs X/Y, no rel X/Y and
 >> BTN_LEFT? Or do you have other crazy devices doing that as well?

 Peter> i'm pretty sure that for any combination of axes you can think
 Peter> of, there will be a device out there that has them. but yes,
 Peter> this keyboard in particular was the first of many to cause the
 Peter> rel/abs handling in evdev.  If it helps, my other Microsft
 Peter> keyboard has REL_HWHEEL and a bunch of ABS_ axes (including some
 Peter> multi-touch axes, but I'm not sure typing really counts as MT
 Peter> interaction).

Ok.

 Peter> the amendment to your patch wouldn't be hard, you'd just have to
 Peter> make sure that devices that don't have buttons don't get
 Peter> labelled as touchscreens and we get your device supported while
 Peter> maintaining the previous behaviour for all other devices.

With the check for BTN_LEFT (or rather has_lmr) that shouldn't be an
issue.

I'l send an updated patch shortly.

-- 
Bye, Peter Korsgaard


More information about the xorg-devel mailing list