Compile problems with ATI theatre200.[ch]

Kean Johnston kean at armory.com
Sun Nov 6 21:56:26 PST 2005


Hi all,

Even on HEAD I am still having compile problems with the
ATI theatre200 code. I mailed the author a few months back,
and this list, and every agreed the solution I proposed was
the right one. The code still hasn't changed. I am attaching
a patch which I would like to commit please. Anyone have any
issues with this?

The problem is simple: the code uses variadic macros, which
are intrinsically non-portable. For any environment not
using gcc or a c99 compiler (many platforms), thats an issue.
The fix is pretty simple, as you can see from the patch.

TIA.

Kean
-- 
"I've seen things you people wouldn't believe...
Attack Ships on fire off the shores of Orion.
I've watched C-beams glitter in the dark off of Tanhauser Gate.
All those moments will be lost in time...like tears, in rain.
Time to die." -- "Roy Batty" - Bladerunner
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: ati.diff
URL: <http://lists.x.org/archives/xorg/attachments/20051106/d50bbcf4/attachment.ksh>


More information about the xorg mailing list