Need review for #3180 please
Kevin E Martin
kem at freedesktop.org
Mon Nov 7 08:21:02 PST 2005
On Sun, Nov 06, 2005 at 10:10:48PM -0800, Kean Johnston wrote:
> I just uploaded a new patch against today's HEAD. This is
> significantly more improved than the last patch, and addresses
> OpenServer 6 as well as OpenServer 5 and UnixWare 7. The only
> outstanding issue I am experiencing is I must diable Xkb as
> its not finding its map files, but thats relatively minor
> (and a genuine bug not a port update) and I will address that
> with a separate patch.
I'm still working my way through your jumbo patch. I think we should
get several people to review this one. So far, the majority of changes
are contained with #if/#endif block for your platforms, but there are
some other changes that affect all platforms. A couple of questions:
- Have you been able to test your patch on other platforms? Since there
are changes to the platform independent code, it would be good to
verify that there are no regressions introduced.
- Have you been able to test with the modular tree? I see at least one
issue so far: Xsession --> Xsession.cpp will require changes to the
For everyone reviewing this patch, the comments in the ChangeLog patch
are very helpful (thanks Kean!).
More information about the xorg